KAFKA-16750: Added acknowledge code in SharePartitionManager including unit tests #16457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirag-wadhwa5
force-pushed
the
KAFKA-16750
branch
from
5f943a7
to
276e4f2
Compare
apoorvmittal10
suggested changes
Jun 26, 2024
core/src/main/java/kafka/server/share/SharePartitionManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/kafka/server/share/SharePartitionManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/kafka/server/share/SharePartitionManager.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java
Outdated
Show resolved
Hide resolved
chirag-wadhwa5
force-pushed
the
KAFKA-16750
branch
from
1986472
to
20f50eb
Compare
apoorvmittal10
approved these changes
Jun 28, 2024
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java
Outdated
Show resolved
Hide resolved
apoorvmittal10
approved these changes
Jul 1, 2024
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java
Outdated
Show resolved
Hide resolved
omkreddy
approved these changes
Jul 2, 2024
chirag-wadhwa5
added a commit
to chirag-wadhwa5/kafka
that referenced
this pull request
Jul 3, 2024
…g unit tests (apache#16457) About This PR adds acknowledge code in SharePartitionManager. Internally, the record acknowledgements happen at the SharePartition level. SharePartitionManager identifies the SharePartitions and calls their acknowledge method to actually acknowledge the individual records Testing Added unit tests to cover the new functionality added in SharePartitionManagerTest Reviewers: Apoorv Mittal <[email protected]>, Manikumar Reddy <[email protected]>
abhi-ksolves
pushed a commit
to ksolves/kafka
that referenced
this pull request
Jul 31, 2024
…g unit tests (apache#16457) About This PR adds acknowledge code in SharePartitionManager. Internally, the record acknowledgements happen at the SharePartition level. SharePartitionManager identifies the SharePartitions and calls their acknowledge method to actually acknowledge the individual records Testing Added unit tests to cover the new functionality added in SharePartitionManagerTest Reviewers: Apoorv Mittal <[email protected]>, Manikumar Reddy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This PR adds acknowledge code in SharePartitionManager. Internally, the record acknowledgements happen at the SharePartition level. SharePartitionManager identifies the SharePartitions and calls their acknowledge method to actually acknowledge the individual records
Testing
Added unit tests to cover the new functionality added in SharePartitionManagerTest